Skip to content

Fix namespaced-role-and-bindings helm chart bugs#406

Open
FarhanTejani wants to merge 1 commit intoaws:mainfrom
FarhanTejani:fix/namespaced-role-enabled-typo
Open

Fix namespaced-role-and-bindings helm chart bugs#406
FarhanTejani wants to merge 1 commit intoaws:mainfrom
FarhanTejani:fix/namespaced-role-enabled-typo

Conversation

@FarhanTejani
Copy link
Copy Markdown
Member

What's changing and why?

Fixing two bugs in the namespaced-role-and-bindings subchart:

  1. Chart.yaml defines the condition as namespaced-role-and-bindings.enabled, but values.yaml uses enable (missing the trailing d). The condition never matches, so the subchart cannot be disabled via values.

  2. The RoleBinding template hardcodes namespace: kubeflow instead of using {{ .Values.namespace }}. The Role on line 4 is correctly templated, but the RoleBinding on line 37 is not. If a user configures a different namespace, the RoleBinding is created in kubeflow while the Role is created in the configured namespace.

Before/After UX

Fix 1:

# values.yaml before
namespaced-role-and-bindings:
  enable: false   # has no effect, subchart always installs

# values.yaml after
namespaced-role-and-bindings:
  enabled: false  # correctly disables the subchart

Fix 2:

# before
metadata:
  namespace: kubeflow  # always kubeflow regardless of config

# after
metadata:
  namespace: {{ .Values.namespace }}  # respects configured namespace

How was this change tested?

  • Verified Chart.yaml line 78 uses namespaced-role-and-bindings.enabled as the condition
  • Confirmed all other subcharts in values.yaml use enabled (this was the only outlier)
  • Confirmed the Role on line 4 already uses {{ .Values.namespace }}

Are unit tests added?

N/A (Helm chart fix)

Are integration tests added?

N/A

Reviewer Guidelines

‼️ Merge Requirements: PRs with failing integration tests cannot be merged without justification.

One of the following must be true:

  • All automated PR checks pass
  • Failed tests include local run results/screenshots proving they work
  • Changes are documentation-only

@FarhanTejani FarhanTejani requested a review from a team as a code owner April 11, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant