Add error topic deletion to clean up of consumer producer#417
Add error topic deletion to clean up of consumer producer#417
Conversation
| @Builder.Default | ||
| @NonNull | ||
| Map<String, String> labeledOutputTopics = emptyMap(); | ||
| String errorTopic; |
There was a problem hiding this comment.
Could this lead to any issues for producers? I wasn't able to spot any issues like that. KafkaProducerApplication simply doesn't set an errorTopic when building ProducerTopicConfig and therefore should be fine I think.
There was a problem hiding this comment.
I am not sure here. I think it might be better to introduce a separate class here
There was a problem hiding this comment.
I mean there is already ConsumerProducerTopicConfig?
There was a problem hiding this comment.
Yes, that class exists to collect all topic info of a ConsumerProducer but it has a method to then obtain a ProducerTopicConfig again so that ProducerCleanUpRunner can be used:
Are you suggesting to add an extra clean up runner in ConsumerProducerCleanUpRunner to clean up the error topic? That would keep the logic separate from the producer clean up.
There was a problem hiding this comment.
Yes I think that makes more sense
2 participants
Currently, running the clean command for a KafkaConsumerProducerApplication does not delete the error topic.