Skip to content

chore(builder): consolidated builder setup on shared node #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danyalprout merged 1 commit into from
Feb 11, 2026
Merged

chore(builder): consolidated builder setup on shared node #682

danyalprout merged 1 commit into from
Feb 11, 2026
+344 −423

Conversation

@danyalprout
Copy link
Collaborator

@danyalprout danyalprout commented Feb 8, 2026 •
edited
Loading

Description

  • Update the builder to use the same node setup as the client, allowing it to share extensions
  • Setup the metering crate as an extension
  • Some misc renamings (BaseBuilder => NodeHooks etc.)

@danyalprout danyalprout mentioned this pull request Feb 8, 2026
Merged
@danyalprout danyalprout changed the title chore(builder): combined builder setup chore(builder): consolidated builder setup on shared node Feb 8, 2026
@danyalprout danyalprout force-pushed the danyal/simplify-builder-setup-2 branch from 1098922 to 715de19 Compare February 9, 2026 20:07
@danyalprout danyalprout force-pushed the danyal/simplify-builder-setup-3 branch from 7fc1d9d to 1aa0257 Compare February 9, 2026 20:07
@danyalprout danyalprout force-pushed the danyal/simplify-builder-setup-2 branch from 715de19 to f59e2cf Compare February 9, 2026 21:55
Base automatically changed from danyal/simplify-builder-setup-2 to main February 9, 2026 22:57
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 9, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout danyalprout force-pushed the danyal/simplify-builder-setup-3 branch from 1aa0257 to 6d999cb Compare February 11, 2026 18:03
@danyalprout danyalprout force-pushed the danyal/simplify-builder-setup-3 branch from da3fc7b to 49e7a04 Compare February 11, 2026 23:09
danyalprout
danyalprout commented Feb 11, 2026
View reviewed changes
crates/builder/core/src/engine.rs
Copy link
Collaborator Author

@danyalprout danyalprout Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something, this is very similar to upstream (and probably redundant).

@danyalprout danyalprout marked this pull request as ready for review February 11, 2026 23:10
@danyalprout danyalprout requested a review from refcell February 11, 2026 23:15
@danyalprout danyalprout added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit 0d8c9af Feb 11, 2026
17 checks passed
@danyalprout danyalprout deleted the danyal/simplify-builder-setup-3 branch February 11, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@refcell refcell refcell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danyalprout @cb-heimdall @refcell