docs: document current_py_cc_headers and related toolchain targets#3602
docs: document current_py_cc_headers and related toolchain targets#3602Saish-3 wants to merge 2 commits intobazel-contrib:mainfrom
Conversation
Summary of ChangesHello @Saish-3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds valuable documentation for current_py_cc_headers and related targets, explaining their purpose and usage. The new section is clear and well-written. I've provided a few minor suggestions to improve formatting consistency with the rest of the document by wrapping target names and keywords in backticks.
| Under bzlmod, a toolchain is registered automatically. In non-bzlmod | ||
| setups, users must ensure that a toolchain is explicitly registered. |
There was a problem hiding this comment.
For consistency with the rest of the document, please wrap bzlmod and non-bzlmod in backticks to format them as code.
| Under bzlmod, a toolchain is registered automatically. In non-bzlmod | |
| setups, users must ensure that a toolchain is explicitly registered. | |
| Under `bzlmod`, a toolchain is registered automatically. In `non-bzlmod` | |
| setups, users must ensure that a toolchain is explicitly registered. |
Adds documentation explaining:
Describes how these targets expose headers and libraries
from the active Python C toolchain and clarifies that they
should be used instead of legacy alias targets when embedding
Python or building C extensions.
This addresses issue #3098.