Skip to content

lastgenre: Test empty last.fm result doesnt wipe#6608

Open
JOJ0 wants to merge 1 commit intomasterfrom
lastgenre_empty_result_regression_test
Open

lastgenre: Test empty last.fm result doesnt wipe#6608
JOJ0 wants to merge 1 commit intomasterfrom
lastgenre_empty_result_regression_test

Conversation

@JOJ0
Copy link
Copy Markdown
Member

@JOJ0 JOJ0 commented May 4, 2026

Add a test case that proves that issue 5991 is fixed by now.

Closes #5991 .

Add a test case that proves that issue 5991 is fixed by now.
Copilot AI review requested due to automatic review settings May 4, 2026 05:52
@JOJ0 JOJ0 requested a review from a team as a code owner May 4, 2026 05:52
@github-actions github-actions Bot added the lastgenre lastgenre plugin label May 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.07%. Comparing base (3d3f5e3) to head (80376a9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6608   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         159      159           
  Lines       20633    20633           
  Branches     3273     3273           
=======================================
  Hits        14871    14871           
  Misses       5053     5053           
  Partials      709      709           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

PR add regression test for lastgenre plugin so existing multi-value genres not get wiped when Last.fm give no tags (issue #5991). This fit beets plugin test suite, guard against old bug come back.

Changes:

  • Add new parametrized case in test_get_genre for whitelist: True + keep_existing: True with empty Last.fm results.
  • Assert "original fallback" keep both existing genres.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lastgenre lastgenre plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lastgenre: existing genre tag with multiple values gets wiped if Last.fm returns no tags

2 participants