Adapt dotnet memory allocations#705
Merged
epompeii merged 17 commits intobencherdev:develfrom Mar 21, 2026
Merged
Conversation
ricardoboss
force-pushed
the
issues/699-dotnet-memory-allocations
branch
from
2841ffc to
8edf525
Compare
epompeii
reviewed
Mar 14, 2026
Member
epompeii
left a comment
epompeii
left a comment
There was a problem hiding this comment.
@ricardoboss thank you for all of your work so far!
I've made a few suggestions and had a couple of questions.
epompeii
requested changes
Mar 16, 2026
ricardoboss
force-pushed
the
issues/699-dotnet-memory-allocations
branch
from
18c15d6 to
315621f
Compare
|
Bencher Report| Branch | issues/699-dotnet-memory-allocations |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| Adapter::Json | 📈 view plot 🚷 view threshold | 3.90 µs(+12.31%)Baseline: 3.48 µs | 4.62 µs (84.44%) |
| Adapter::Magic (JSON) | 📈 view plot 🚷 view threshold | 3.98 µs(+15.17%)Baseline: 3.46 µs | 4.52 µs (88.02%) |
| Adapter::Magic (Rust) | 📈 view plot 🚷 view threshold | 25.39 µs(-1.04%)Baseline: 25.65 µs | 31.05 µs (81.75%) |
| Adapter::Rust | 📈 view plot 🚷 view threshold | 2.91 µs(+2.06%)Baseline: 2.85 µs | 3.34 µs (87.20%) |
| Adapter::RustBench | 📈 view plot 🚷 view threshold | 2.89 µs(+1.60%)Baseline: 2.85 µs | 3.32 µs (87.21%) |
| head_version_insert/batch/10 | 📈 view plot 🚷 view threshold | 109.25 µs(+9.09%)Baseline: 100.15 µs | 120.45 µs (90.70%) |
| head_version_insert/batch/100 | 📈 view plot 🚷 view threshold | 250.60 µs(+5.59%)Baseline: 237.33 µs | 266.98 µs (93.86%) |
| head_version_insert/batch/255 | 📈 view plot 🚷 view threshold | 481.82 µs(+4.47%)Baseline: 461.21 µs | 492.34 µs (97.86%) |
| head_version_insert/batch/50 | 📈 view plot 🚷 view threshold | 170.48 µs(+6.27%)Baseline: 160.42 µs | 182.51 µs (93.41%) |
| threshold_query/join/10 | 📈 view plot 🚷 view threshold | 162.62 µs(+12.60%)Baseline: 144.42 µs | 170.07 µs (95.62%) |
| threshold_query/join/20 | 📈 view plot 🚷 view threshold | 174.69 µs(+10.17%)Baseline: 158.57 µs | 186.03 µs (93.90%) |
| threshold_query/join/5 | 📈 view plot 🚷 view threshold | 150.22 µs(+10.11%)Baseline: 136.42 µs | 159.81 µs (94.00%) |
| threshold_query/join/50 | 📈 view plot 🚷 view threshold | 218.66 µs(+9.34%)Baseline: 199.99 µs | 232.82 µs (93.92%) |
epompeii
reviewed
Mar 17, 2026
Member
epompeii
left a comment
epompeii
left a comment
There was a problem hiding this comment.
@ricardoboss it is looking good!
You just need to run some final cleanup and you should be good to go.
cargo fmtcargo clippy(to be extra sure you can run./scripts/clippy.shto run exactly what is run in CI)
This reverts commit 4dddf99.
Co-authored-by: Everett Pompeii <epompeii@protonmail.com>
ricardoboss
force-pushed
the
issues/699-dotnet-memory-allocations
branch
from
50468e1 to
3dd5e41
Compare
epompeii
approved these changes
Mar 21, 2026
Member
epompeii
left a comment
epompeii
left a comment
There was a problem hiding this comment.
Thank you @ricardoboss!
Great work! 🦀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699
Adds handling for the
memorykey in BenchmarkDotNet, in case C# benchmarks are run with the[MemoryDiagnoser]attribute.If found, adds a new metric
allocatedmeasured in bytes.