Option<I> SystemInput#23712
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Apr 12, 2026
Merged
Conversation
cookie1170
approved these changes
Apr 8, 2026
Diddykonga
approved these changes
Apr 8, 2026
alice-i-cecile
approved these changes
Apr 12, 2026
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
I'd prefer World::run_system_once in tests, but that's just a style nit :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Currently, if users want a system to take
Option<&mut T>orOption<&T>as system input, they need to either useInMut<Option<T>>/InRef<Option<T>>which actually result in a&mut Option<T>/&Option<T>, or create their ownSystemInputtype.Solution
Implement
SystemInputforOption<I>whereIcan be anySystemInputtype.Testing
Added a test for this.