Skip to content

Use RwLockWriteGuard::downgrade in BevyManifest#23739

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
DavidCrossman:bevy_manifest_downgrade_lock
Apr 12, 2026
Merged

Use RwLockWriteGuard::downgrade in BevyManifest#23739
alice-i-cecile merged 1 commit intobevyengine:mainfrom
DavidCrossman:bevy_manifest_downgrade_lock

Conversation

@DavidCrossman
Copy link
Copy Markdown
Contributor

@DavidCrossman DavidCrossman commented Apr 9, 2026

Objective

  • Bevy's MSRV is now 1.92; the release which stabilised RwLockWriteGuard::downgrade. The API can now be used in BevyManifest.

Solution

  • Use the new API.

Testing

  • cargo run -p ci -- compile

@kfc35 kfc35 added D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 9, 2026
@alice-i-cecile alice-i-cecile added D-Macros Code that generates Rust code S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 12, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 12, 2026
Merged via the queue into bevyengine:main with commit a6d7527 Apr 12, 2026
51 checks passed
@DavidCrossman DavidCrossman deleted the bevy_manifest_downgrade_lock branch April 12, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Utils Utility functions and types C-Code-Quality A section of code that is hard to understand or change D-Macros Code that generates Rust code D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidCrossman @alice-i-cecile @kfc35