Update dependencies and middleware for Faraday integration#186
Update dependencies and middleware for Faraday integration#186markcmurphy wants to merge 7 commits intobigcommerce:masterfrom
Conversation
- Updated Faraday dependency to version >= 2.14 and removed Faraday Middleware. - Refactored connection and middleware classes to use the new Faraday request authorization method. - Adjusted tests to reflect changes in middleware expectations.
- Updated the `call` method to use a new private method `option_value` for retrieving options, allowing for both symbol and string keys. - Added tests to ensure correct header setting when options are provided with string keys.
- Updated the `parse` method to handle gzip encoded JSON responses by adding a `decode_body` method. - Modified the `build_response_object` method to pass response headers to the `parse` method. - Added tests to verify the correct decoding and object building for gzip encoded responses.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2cf8fc1af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- chatgpt-codex-connector[bot]: restore gzip decoding for raw_request and delete responses - add unit coverage for gzip decoding in delete and raw_request
j05h
left a comment
j05h
left a comment
There was a problem hiding this comment.
This is likely a major version bump same as Faraday. You'll want to update the version file as well.
At a minimum, we'll be going to v 1.2.0.
- Updated version to 2.0.0 in `version.rb`. - Added entry for the release in `CHANGELOG.md`, noting the update to Faraday 2.14 and support for Ruby 3.4.
- Added `faraday-gzip` as a dependency to enable gzip request and response compression. - Updated the Bigcommerce connection to use gzip middleware for requests. - Modified the request handling to simplify response body processing by removing gzip decoding logic. - Updated tests to verify the inclusion of gzip middleware in the request pipeline.
exeDog
left a comment
exeDog
left a comment
There was a problem hiding this comment.
Nice work!
Can we quickly pull this gem version into developer portal and do a confidence check that everything is working as expected?
Yes, but we're now blocked because |
@exeDog, I pulled this in and pinned to the updated |
3 participants
What?
Tickets / Documentation
Screenshots (if appropriate)
Successfully ran time script: