refactor: use CustomAwsCredentialLoader for dynamic AWS credentials#22
Merged
refactor: use CustomAwsCredentialLoader for dynamic AWS credentials#22
Conversation
Instead of extracting credential strings from SdkConfig, stuffing them into FileIO props, then extracting them again to build S3 clients: - Implement AwsCredentialLoad to wrap SharedCredentialsProvider, so iceberg's storage layer can refresh credentials dynamically - Pass aws_sdk_s3::Client directly for S3 prefix listing, rather than reconstructing it from FileIO props - s3_file_io() is now sync and infallible - Drop direct reqsign dep; downgrade reqwest to 0.12 to match iceberg-storage-opendal's AwsCredentialLoad trait Closes #21 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AwsCredentialLoadto wrapSharedCredentialsProvider, so iceberg's storage layer can refresh credentials dynamically instead of using static stringsaws_sdk_s3::Clientdirectly for S3 prefix listing, rather than reconstructing it from FileIO propss3_file_io()is now sync and infalliblereqsigndep; downgradereqwestto 0.12 to matchiceberg-storage-opendal'sAwsCredentialLoadtraitCloses #21
🤖 Generated with Claude Code