feat: add Namespace type with validation and hardcode metadata S3 prefix#239
Merged
alecthomas merged 1 commit intomainfrom Mar 30, 2026
Merged
feat: add Namespace type with validation and hardcode metadata S3 prefix#239alecthomas merged 1 commit intomainfrom
alecthomas merged 1 commit intomainfrom
Conversation
Introduce cache.Namespace as a named string type with TextUnmarshaler-based validation. Names must match ^[a-zA-Z0-9][a-zA-Z0-9_-]*$, preventing collisions with the .metadata/ prefix used by the S3 metadata backend. - Replace string namespace parameters throughout the Cache interface and all implementations with the Namespace type - Remove configurable Prefix from metadatadb S3BackendConfig, hardcode .metadata as the prefix - Validate namespaces at API boundaries (HTTP handlers, strategy creation, CLI via Kong TextUnmarshaler) - Change Remote default namespace from "-" to "default" Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce cache.Namespace as a named string type with
TextUnmarshaler-based validation. Names must match
^[a-zA-Z0-9][a-zA-Z0-9_-]*$, preventing collisions with the
.metadata/ prefix used by the S3 metadata backend.
and all implementations with the Namespace type
.metadata as the prefix
creation, CLI via Kong TextUnmarshaler)
Co-authored-by: Claude Code noreply@anthropic.com