Do not generate s500 since it conflicts with Ping1D Message definition#168
Open
patrickelectric wants to merge 1 commit intobluerobotics:masterfrom
Open
Do not generate s500 since it conflicts with Ping1D Message definition#168patrickelectric wants to merge 1 commit intobluerobotics:masterfrom
patrickelectric wants to merge 1 commit intobluerobotics:masterfrom
Conversation
patrickelectric
requested review from
ES-Alexander,
joaoantoniocardoso and
joaomariolago
Conflict with Ping1D definition of message for set speed of sound, where they use same id by different units Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
fix-ping
branch
from
1d1174a to
922a7e1
Compare
| definitions.PING360_DEVICE_DATA, | ||
| definitions.PING360_AUTO_DEVICE_DATA, | ||
| definitions.SURVEYOR240_ATOF_POINT_DATA, | ||
| definitions.SURVEYOR240_YZ_POINT_DATA, |
Member
There was a problem hiding this comment.
was this removal intentional?
Member
Author
There was a problem hiding this comment.
Nops, thanks for noticing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.