Skip to content

Highlight nested CEL fields#4342

Merged
stefanvanburen merged 2 commits intomainfrom
svanburen/handle-nested-cel-fields
Feb 19, 2026
Merged

Highlight nested CEL fields#4342
stefanvanburen merged 2 commits intomainfrom
svanburen/handle-nested-cel-fields

Conversation

@stefanvanburen
Copy link
Member

Protovalidate supports repeated.items.cel{,_expression} and map.{keys,values}.cel{,_expression}; we want to make sure we highlight these nested strings that ought to be handled as CEL.

This also updates the CEL tests to use the vendored protovalidate approach that we use in the bufcheck tests.

Protovalidate supports `repeated.items.cel{,_expression}` and
`map.{keys,values}.cel{,_expression}`; we want to make sure we highlight
these nested strings that ought to be handled as CEL.

Found by @pkwarren.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 20, 2026, 5:45 AM

@stefanvanburen stefanvanburen marked this pull request as ready for review February 19, 2026 13:40
@stefanvanburen stefanvanburen merged commit ffccea6 into main Feb 19, 2026
12 checks passed
@stefanvanburen stefanvanburen deleted the svanburen/handle-nested-cel-fields branch February 19, 2026 14:51
stefanvanburen added a commit that referenced this pull request Feb 19, 2026
Quick follow-up to #4341 to follow the approach from #4342. (Might be
good to consolidate these to a single testdata/ somewhere, maybe, but
I think it's ok to continue with this pattern for now; we don't plan to
add too many more of these.)
stefanvanburen added a commit that referenced this pull request Feb 19, 2026
Quick follow-up to #4341 to follow the approach from #4342. (Might be
good to consolidate these to a single testdata/ somewhere, maybe, but
I think it's ok to continue with this pattern for now; we don't plan to
add too many more of these.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments