Merged
Conversation
fix typo in argument declaration, renaming maxFileSize to maxFilesize for Dropzone component according to documentation https://docs.dropzone.dev/configuration/basics/configuration-options
Collaborator
|
Thanks, can confirm. When we had a lower limit we indeed also spelled it correctly ;) https://github.com/buildingSMART/validate/blame/86f8abcddba7b6e3256d622628bc207f9dc08b1b/frontend/src/Dz.js#L19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix typo in argument declaration.
renaming argument maxFileSize to maxFilesize for Dropzone component according to documentation https://docs.dropzone.dev/configuration/basics/configuration-options.
Since Dropzone.maxFilesize default limit is 256 MB, the bug may have been transparent but modifying the value of the variable MAX_FILE_SIZE_IN_MB shows it is not taken into account.