Open
Conversation
|
|
Author
|
lol i notice this pr that's great one! but i think my pr is a proper one. docker-compose is a heavy solution. In this project, the frontend doesn't have to be hosted on the same machine with backend. Since we use nextjs, vercel-frontend-deployment is a more elegent one. No need to host frontend in a docker-compose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through this PR, we can build the Python backend into a Docker image and expose an endpoint. This is very useful for deployment, as many cloud function providers—such as Volcano Engine, Alibaba Cloud, AWS, and GCP—support running a Docker image as a serverless function. Serverless functions can significantly reduce the cost burden for deployers.