fix: unicode is handled properly in strdist#280
Open
letFunny wants to merge 2 commits intocanonical:mainfrom
Open
fix: unicode is handled properly in strdist#280letFunny wants to merge 2 commits intocanonical:mainfrom
letFunny wants to merge 2 commits intocanonical:mainfrom
Conversation
letFunny
commented
Apr 2, 2026
| } | ||
| _ = stop | ||
| if cut != 0 && stop { | ||
| if cut != 0 && len(b) > 0 && stop { |
Collaborator
Author
There was a problem hiding this comment.
This is not strictly related to unicode but it made the test fail when the second string was empty so I fixed it as well.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing more performance work I noticed a couple of bugs in our implementation of distance. I will fix each one of them in a different PR so that the perf work can land. I have added a TODO for the next bug. I don't want to fix both as part of the same PR as it will be much harder to reason about the code, the fix for unicode in itself is pretty easy.