fix: ci#306
Conversation
There was a problem hiding this comment.
The PR introduces a full CI/CD setup but has several correctness and security issues that must be addressed before merging: the release.yml workflow is missing the NODE_AUTH_TOKEN secret needed to actually publish to npm and uses stale action versions; lint-prettier.yml has checkout/setup-node in the wrong order; both test.yml jobs use an outdated actions/setup-node@v2; issue.yml is missing await on the GitHub API call; CF credentials are interpolated unquoted into shell commands in both performance.yml and the composite action; and the performance workflow's cds up will block all subsequent steps while also leaving no cleanup for the deployed application.
PR Bot Information
Version: 1.20.37
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - Correlation ID:
ae7b0b47-2d6d-4855-8ee1-78737689c7a9
use a cooldown of 7 days to reduce the risk of supply chain attacks in CI
SummaryThe following content is AI-generated and provides a summary of the pull request: Fix CI Workflows and Add GitHub ConfigurationChore🔧 Introduced the Changes
PR Bot InformationVersion:
|
There was a problem hiding this comment.
The PR introduces the entire .github/ CI infrastructure. Several substantive issues were found: a broken local-action reference that will fail immediately at parse time, a step-ordering bug that causes the CDS-8 dependency overrides to be applied after npm install in the SQLite test job, insecure kubeconfig file permissions in the performance workflow, an end-of-life v3 action pair in the release workflow, and a few logic/cleanup concerns around CF undeploy error handling and package.json mutation during HANA binding.
PR Bot Information
Version: 1.20.37
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Correlation ID:
a2134578-67f8-47b6-aa86-8c9268db1d78 - Event Trigger:
pull_request.ready_for_review
Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
Co-authored-by: Patrice Bender <info@patrice.codes>
Co-authored-by: Patrice Bender <info@patrice.codes>
Co-authored-by: Patrice Bender <info@patrice.codes>
Steps taken here:
github.event.pull_request.base.user.logintogithub.event.pull_request.head.repo.owner.loginin test and performance workflowrequires-approvalstep is only skipped if the PR does not come from a fork by the following condition:if: github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.owner.login != 'cap-js'. The first part of the following condition is true when the PR comes from a fork and the run was approved, and the second part is true if the PR does not come from a fork:(needs.requires-approval.result == 'success' || needs.requires-approval.result == 'skipped')PERF_CLUSTER_KUBECONsecret from workflow to stepcf logintocf auth