feat: support SPM by using capacitor migration tool#673
feat: support SPM by using capacitor migration tool#673paulstelzer wants to merge 1 commit intocapacitor-community:masterfrom
Conversation
|
Here is a dev version for testing: |
|
Hi, I have tested it with encrypted data and works with no issues. |
|
Thank you for taking care of the further development of the plugin! Good luck with it. We have installed the development version, but we are getting SCALAR VIOLATION errors. Looking at GitHub, it seems that this problem was already solved in 2022 (see #319 ) Currently, we obtain values as follows Now we would have to do it this way (so that it also works on Android) Which is correct, option 1 or 2? Thanks EDIT: This indicates that somewhere in the iOS code, ios_columns is still being generated (likely in fetchColumnData or similar), but should be filtered out before returning results to the JavaScript layer.
Impact: This breaks API consistency between Android and iOS. Our workaround (Option 2) works but forces platform-specific handling in JavaScript, which defeats the purpose of a cross-platform plugin. |
|
I tested this build and went from to a working app. |
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/ionic-team/capacitor-swift-pm.git", from: "8.0.0"), | ||
| .package(url: "https://github.com/sqlcipher/SQLCipher.swift.git", from: "4.12.0"), |
There was a problem hiding this comment.
We should only allow patch and minor versions here to prevent breaking changes. Same for zipfoundation.
There was a problem hiding this comment.
Please restore the order of the properties so that it's easier to identify the important changes.
robingenz
left a comment
There was a problem hiding this comment.
Please resolve the merge conflicts.
|
quick follow-up: Any timeline or update on when this PR might progress? The key goal is consistent cross-platform query results—no more iOS-specific Thanks for any info! |
|
@true-perfect-code Feel free to debug it and suggest a solution. It would be great if you could coordinate with @paulstelzer to include the fix in the PR. |
|
Thanks for the quick reply and the invitation @robingenz! We coming from a pure .NET C# background and using Capacitor only from the Blazor WASM / JS side, we're unfortunately not in a position to propose changes to the native Swift/Objective-C layer. Any suggestions from a team without deep native iOS experience could unfortunately introduce subtle issues that would then require even more time and effort from the actual native developers to review and correct. For that reason we'd prefer to leave the native-side work to folks more familiar with that part of the codebase. We're happy to keep helping with reproduction steps, logs or web/JS-side observations if useful. Thanks again for maintaining the project! |
Add support for SPM using the official capacitor tool https://github.com/ionic-team/capacitor-plugin-converter
All changes made by the tool. I am only adjusted the Package.swift to add ZIPFoundation and SQLCipher.
I have tested in my own project and it seems to work. Would be great if other could test it too. I am only tested with unencrypted data (not with decrypted data)
Fixes #568