update md5 usage for FIPS compliance#630
Open
miknevinas wants to merge 5 commits intomasterfrom
Open
Conversation
Contributor
|
this set of code still has a call to md5 without the 'usedforsecurity=False' kw arg -- so scanners are still gonna pick it up and have a problem with it. we need to see if we can just migrate to a FIPS compliant hash instead |
Contributor
Author
|
Also it looks like 'usedforsecurity=False' is is only supported in python 3.9+, which I was not aware of, so we'll probably have to go with sha256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.