Skip to content

add httponly and secure settings to secure login auth cookie #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zombified wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add httponly and secure settings to secure login auth cookie #635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
075519a
add httponly and secure settings to secure login auth cookie
zombified Apr 1, 2026
66485e9
ensure HttpOnly flag is added to cookie on login
Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion castle/cms/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from zope.component import adapter
from zope.component import getGlobalSiteManager
from zope.component import getUtility
from zope.component.hooks import getSite
from zope.component.interfaces import ComponentLookupError
from zope.event import notify
from zope.interface import Interface
Expand Down Expand Up @@ -130,7 +131,35 @@ def get_supported_auth_schemes(self):

def set_login_session_id(self):
self.login_session_id = uuid4()
self.request.response.setCookie('__sl__', self.login_session_id)

if not self.is_zope_root and self.registry:
use_secure = (
self.registry.get('castle.use_secure_cookie', 'yes')
.lower().strip() == 'yes'
)

use_http_only = (
self.registry.get('castle.use_httponly_cookie', 'yes')
.lower().strip() == 'yes'
)

site = getSite()
site_path = '/'.join(site.getPhysicalPath()).lstrip('/')
cookie_path = '/' + site_path if site_path else '/'

cookie = '__sl__=%s; Path=%s;' % (self.login_session_id, cookie_path)

if use_secure:
cookie += '; Secure'

if use_http_only:
cookie += '; HttpOnly'

self.request.response.addHeader('Set-Cookie', cookie)

else:
self.request.response.setCookie('__sl__', self.login_session_id)


def get_secure_flow_key(self):
return '{id}-secure-state'.format(id=self.login_session_id)
Expand Down