feat: create tasks to clean sandbox store#1
Open
natthan-pigoux wants to merge 13 commits intochrisburr:feat/tasksfrom
Open
feat: create tasks to clean sandbox store#1natthan-pigoux wants to merge 13 commits intochrisburr:feat/tasksfrom
natthan-pigoux wants to merge 13 commits intochrisburr:feat/tasksfrom
Conversation
natthan-pigoux
changed the title
Author
chrisburr
force-pushed
the
feat/tasks
branch
6 times, most recently
from
313b805 to
65f2e76
Compare
chrisburr
force-pushed
the
feat/tasks_clean_sb_store
branch
2 times, most recently
from
c364a62 to
a17e121
Compare
chrisburr
force-pushed
the
feat/tasks
branch
2 times, most recently
from
14fa1d3 to
f8313ef
Compare
* feat: add diracx-tasks --------- Co-authored-by: Christophe Haen <christophe.haen@cern.ch>
The _validate_guid function was forcing GUIDs to uppercase, causing FID mismatches in downstream systems (e.g. RootIOHandler) that perform case-sensitive comparisons against the file's original GUID.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.15.8 → v0.15.9](astral-sh/ruff-pre-commit@v0.15.8...v0.15.9) - [github.com/pre-commit/mirrors-mypy: v1.19.1 → v1.20.0](pre-commit/mirrors-mypy@v1.19.1...v1.20.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The variable signature used for dependency injection violates the Liskov Substiution Principle and makes it impossible to run type checkers without ignore comments.
chrisburr
force-pushed
the
feat/tasks_clean_sb_store
branch
from
a17e121 to
b842dbf
Compare
Add __init__.py to test subdirectories and diracx-tasks/src/diracx/tasks/jobs/ that were implicit namespace packages. Enable the INP ruff ruleset to prevent this class of bug in the future.
Re-export NoTransaction from the plumbing layer so task authors can import from diracx.tasks.depends rather than reaching into plumbing internals.
Use diracx.tasks.depends instead of the non-existent .depends module. Populate jobs/__init__.py to re-export CleanSandboxStoreTask as expected by the entry point definition.
Add a parametrized test that calls .load() on every registered diracx.* entry point. This catches broken imports that would otherwise only surface at runtime.
Update documentation examples to import NoTransaction and CallbackSpawner from diracx.tasks.depends instead of reaching into diracx.tasks.plumbing.depends. Also add CallbackSpawner to the public re-export.
chrisburr
force-pushed
the
feat/tasks_clean_sb_store
branch
from
f8067e0 to
bf7b1a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.