feat: add typed EventMap for Paper and Graph with IDE autocomplete#3233
Merged
Geliogabalus merged 2 commits intoclientIO:masterfrom Mar 18, 2026
Merged
Conversation
- Add LiteralUnion<T> and ExcludeIndexSignature<T> utility types - Add Paper.DefinedEventMap (EventMap without index signature) for IDE autocomplete - Add paper:mouseenter and paper:mouseleave to Paper.EventMap - Add typed on() overloads to Paper using DefinedEventMap - Add Graph.EventMap with cell, change:*, layer, and batch events - Add Graph.DefinedEventMap and typed on() overloads to Graph - Preserve backwards compatibility: EventMap keeps index signature Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Geliogabalus
requested changes
Mar 18, 2026
51555e5 to
2382248
Compare
- Add LiteralUnion<T> and ExcludeIndexSignature<T> utility types - Add mvc.EventCallbackMap<T> generic utility for partial event maps - Add Paper.DefinedEventMap (EventMap without index signature) for IDE autocomplete - Add paper:mouseenter and paper:mouseleave to Paper.EventMap - Add typed on() overloads to Paper using DefinedEventMap - Add Graph.EventMap with cell, change:*, layer, and batch events - Add Graph.DefinedEventMap and typed on() overloads to Graph - Preserve backwards compatibility: EventMap keeps index signature Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2382248 to
ef90cab
Compare
Geliogabalus
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LiteralUnion<T>andExcludeIndexSignature<T>utility typesPaper.DefinedEventMapandGraph.DefinedEventMap— stripped of index signatures for IDE autocompleteon()overloads to bothPaperandGraphusingDefinedEventMapGraph.EventMapwith cell collection,change:${string}, layer, and batch eventspaper:mouseenterandpaper:mouseleavetoPaper.EventMapEventMapretains its index signatureTest plan
yarn test-tspassespaper.on('...')andgraph.on('...')paper.on('my-custom', cb)andpaper.on({ 'my-custom': cb })🤖 Generated with Claude Code