refactor(types): simplify EventMap by removing DefinedEventMap and EventCallbackMap#3237
Merged
samuelgja merged 1 commit intoclientIO:masterfrom Mar 18, 2026
Merged
Conversation
…and EventCallbackMap Use EventMap directly in on() overloads — the index signature allows arbitrary strings while TS still infers specific callback types from literal keys. ExcludeIndexSignature is used inline where needed for LiteralUnion autocomplete. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
samuelgja
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Graph.DefinedEventMap,Paper.DefinedEventMap, andmvc.EventCallbackMap<T>EventMapdirectly inon()overloads — TS infers specific callback types from literal keysExcludeIndexSignature<EventMap>inline forLiteralUnionautocompletePartial<EventMap>for the object overloadSimpler approach: the index signature on
EventMapalready allows arbitrary strings, so a separateDefinedEventMaptype is unnecessary.Test plan
yarn test-tspasses🤖 Generated with Claude Code