Update C++ module bindings to RawModuleDefV10#4461
Merged
clockwork-labs-bot merged 5 commits intomasterfrom Feb 28, 2026
Merged
Update C++ module bindings to RawModuleDefV10#4461clockwork-labs-bot merged 5 commits intomasterfrom
clockwork-labs-bot merged 5 commits intomasterfrom
Conversation
rekhoff
reviewed
Feb 27, 2026
Contributor
rekhoff
left a comment
There was a problem hiding this comment.
This looks good overall, with a few minor items. In response to the specific Reviewer questions:
- This looks to cover the V10 code paths and lines up with the work I had done in C#.
- As for the
*_NAMEDmacros, I can't think of a better solution with C++20.
rekhoff
approved these changes
Feb 27, 2026
Contributor
rekhoff
left a comment
There was a problem hiding this comment.
Changes look good. All reviewer items addressed, marking my approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
view and field/index macros).
migration alias.
wrappers.
legacy/full suite.
API and ABI breaking changes
Expected complexity level and risk
3 - Large set of changes moving over to V10 with underlying changes to make future updates a little easier
Testing
spacetime init --template basic-cppReview