Add SolidJs integration#4495
Draft
DanielBaumert wants to merge 2 commits intoclockworklabs:masterfrom
Draft
Conversation
|
|
Razboy20
reviewed
Feb 28, 2026
Razboy20
left a comment
Razboy20
left a comment
There was a problem hiding this comment.
Hi! Note I am not a contributor to SpacetimeDB, just happy for this PR. :)
As a SolidJS enjoyer myself, couple reactivity thoughts:
Use resources and stores instead of pure signals everywhere, and give useTable fine-grained reactivity.
solid-primitives db-store code example for integrating stores, useful read
Or create a resource with deep signals? Not sure
Comment on lines
+58
to
+60
| const [rows, setRows] = createSignal< | ||
| readonly Prettify<UseTableRowType>[] | ||
| >([]); |
There was a problem hiding this comment.
This should probably be a store, updated with reconcile.
|
|
||
| const connectionState: ConnectionState = useSpacetimeDB(); | ||
|
|
||
| const [rows, setRows] = createSignal< |
There was a problem hiding this comment.
It doesn't look like setRows is called anywhere except in full snapshot updates
DanielBaumert
force-pushed
the
feature/solidjs-integration
branch
from
959f5bb to
8234731
Compare
Author
|
A big thank you @Razboy20, Do you see any other problems? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add support for SolidJs
API and ABI breaking changes
None
Expected complexity level and risk
Complexity level: 1
Risk level: 1
Testing