Fix TypeScript optional reducer params to allow omitted keys#4518
Open
akshxdevs wants to merge 1 commit intoclockworklabs:masterfrom
Open
Fix TypeScript optional reducer params to allow omitted keys#4518akshxdevs wants to merge 1 commit intoclockworklabs:masterfrom
akshxdevs wants to merge 1 commit intoclockworklabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix TypeScript row inference so .optional() fields become optional object keys instead of required keys whose values may be undefined.
This resolves the reducer/view parameter typing issue described in #4516, where callers were forced to explicitly pass undefined for omitted optional fields.
Changes
Example
Before:
await conn.reducers.updateCategory({
id: BigInt(1),
name: "updated category name",
buttonText: undefined,
headerText: undefined,
deleted: undefined,
});
After:
await conn.reducers.updateCategory({
id: BigInt(1),
name: "updated category name",
});
Verification
pnpm test:typecheck
Closes #4516