#704: Bumped to SpringBoot4, SpringFramework7 and JDK17 by Stromner · Pull Request #705 · cloudevents/sdk-java

Stromner · 2026-01-08T12:47:24Z

Resolves issue #704

jacekbilski · 2026-01-16T10:10:59Z

Are you sure you want to require Java 25? Seems a bit high to me. Spring Boot 4/Framework 7 require Java 17, the same with Jackson 3. I personally would have no issues with 25, but the broader community might not be ready yet.

Stromner · 2026-01-23T14:14:08Z

You're right, probably too excessive. I've downgraded it to 17. Jackson2 is deprecated in Spring Framework 7, it also causes a lot of extra headache if you try to run this in a project that is Spring Framework 7 and having to either be stuck using Jackson2 or shoehorn in both versions of the dep.

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Stromner · 2026-01-26T06:24:04Z

Ready for review again

danjee · 2026-01-26T07:42:22Z

Hello, any thoughts when a new version with these changes will be released?

jacekbilski · 2026-02-09T14:07:25Z

Ready for review again

Do you want a review from someone in particular, or a random guy from the Internet would also be OK? I might find some time this or next week, but I cannot promise anything. Still, I'm blocked with upgrades because of cloudevents so I'll try to find the time.

Stromner · 2026-02-09T17:36:47Z

Do you want a review from someone in particular, or a random guy from the Internet would also be OK?

I always welcome extra eyes on code I've written so by all means if it interest you! Otherwise it was a maintainer I'm waiting for so it might get approved some day

jacekbilski

Any particular reason why did you drop JAX-RS modules. I haven't found any mention here, that would mention, that they're deprecated or obsolete. And JAX-RS as a standard is not dead.

Current review I made just by looking at the code and building the project myself. I'll try to actually build my app next week and give it a spin. But, apart from the JAX-RS question above, I haven't found any showstoppers. Thanks for the effort.

jacekbilski · 2026-02-13T12:44:53Z

examples/spring-function/src/main/java/io/cloudevents/examples/spring/DemoApplication.java

 public class DemoApplication {
-
-	public static void main(String[] args) throws Exception {
+	static void main(String[] args) {


It needs to be public in Java 17.

jacekbilski · 2026-02-13T13:25:30Z

formats/json-jackson/pom.xml

-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>com.fasterxml.jackson</groupId>
-                <artifactId>jackson-bom</artifactId>
-                <version>${jackson.version}</version>
-                <scope>import</scope>
-                <type>pom</type>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-


Just my personal preference, but I tend to use BOMs more, feel somehow like a cleaner approach.

jacekbilski · 2026-02-13T13:28:28Z

pom.xml

-        <junit-jupiter.version>5.7.0</junit-jupiter.version>
+        <assertj-core.version>3.27.6</assertj-core.version>
+        <junit-jupiter.version>6.0.1</junit-jupiter.version>
+        <jackson.version>3.0.3</jackson.version>


I'd personally push it back to cloudevents-json-jackson. JSON is just one of supported formats, I don't see why it deserves such importance to be mentioned at the top level.

jacekbilski · 2026-02-13T13:31:07Z

pom.xml

+        <maven.compiler.source>${java.version}</maven.compiler.source>
+        <maven.compiler.target>${java.version}</maven.compiler.target>


Suggested change

<maven.compiler.source>${java.version}</maven.compiler.source>

<maven.compiler.target>${java.version}</maven.compiler.target>

<maven.compiler.release>${java.version}</maven.compiler.release>

jacekbilski · 2026-02-13T13:31:45Z

pom.xml

-                        <link>https://fasterxml.github.io/jackson-databind/javadoc/2.10/</link>
                    </links>
-                    <source>8</source>
+                    <source>17</source>


Suggested change

<source>17</source>

<source>${java.version}</source>

jacekbilski · 2026-02-13T13:42:26Z

spring/src/test/java/io/cloudevents/spring/mvc/MvcRestControllerTests.java

-class Foo {
+    static class Foo {
+        private String value;

-	private String value;
-
-	public Foo() {
-	}
-
-	public Foo(String value) {
-		this.value = value;
-	}
-
-	public String getValue() {
-		return this.value;
-	}
-
-	public void setValue(String value) {
-		this.value = value;
-	}
-
-	@Override
-	public String toString() {
-		return "Foo [value=" + this.value + "]";
-	}
+        public String getValue() {
+            return this.value;
+        }

+        @Override
+        public String toString() {
+            return "Foo [value=" + this.value + "]";
+        }
+    }


My proposal would be:

record Foo( String value ) {}

jacekbilski · 2026-02-13T13:44:07Z

spring/src/test/java/io/cloudevents/spring/webflux/WebFluxRestControllerTests.java

 	}

-}
+    static class Foo {


Same here, simply use a record.

jacekbilski · 2026-02-13T13:48:48Z

sql/src/test/java/io/cloudevents/sql/TCKTestSuite.java

    public Stream<Map.Entry<String, TestCaseModel>> tckTestCases() {
-        ObjectMapper mapper = new YAMLMapper();
-        mapper.registerModule(JsonFormat.getCloudEventJacksonModule());
+        ObjectMapper mapper = YAMLMapper.builder().addModule(JsonFormat.getCloudEventJacksonModule()).build();


I can see that you didn't "break" it, but using YAMLMapper together with JsonFormat feels wrong. Just mentioning it, maybe it's working anyway.

jacekbilski · 2026-02-13T15:15:39Z

I ran https://docs.openrewrite.org/recipes/java/spring/boot4/upgradespringboot_4_0-community-edition#usage and it found some issues. For example, there are still some javax.* imports. I'll be investigating this further.

Stromner changed the title ~~Issue 704: Bumped to SpringBoot4, SpringFramework7 and JDK25~~ #704: Bumped to SpringBoot4, SpringFramework7 and JDK25 Jan 8, 2026

Stromner force-pushed the main branch from 58ffc24 to 3eed7c1 Compare January 8, 2026 12:50

Stromner changed the title ~~#704: Bumped to SpringBoot4, SpringFramework7 and JDK25~~ #704: Bumped to SpringBoot4, SpringFramework7 and JDK17 Jan 23, 2026

David Strömner added 7 commits January 23, 2026 15:38

SpringBoot4;SpringFramework7;JDK25

324d591

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Removed deprecated restful-ws modules

346dfc6

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Jackson3

cb1fd47

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Cleanup

df92c52

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Upgraded versioning

f3eefcb

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Fixed feedback cloudevents#1

8d75a3c

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Fixed missed downgrades

846d768

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Stromner force-pushed the main branch from aff92f3 to 846d768 Compare January 23, 2026 14:38

Fixing workflow job

5fb1f87

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Stromner force-pushed the main branch 2 times, most recently from a1e3fca to cfd9af3 Compare January 26, 2026 05:53

Fixed it module

8f80034

Signed-off-by: David Strömner <david.stromner@stralfors.se>

Stromner force-pushed the main branch from cfd9af3 to 8f80034 Compare January 26, 2026 06:13

Fixed maven-javadoc-plugin error

7b6fc5a

Signed-off-by: David Strömner <david.stromner@stralfors.se>

jacekbilski reviewed Feb 13, 2026

View reviewed changes

		<maven.compiler.source>${java.version}</maven.compiler.source>
		<maven.compiler.target>${java.version}</maven.compiler.target>

	<maven.compiler.source>${java.version}</maven.compiler.source>
	<maven.compiler.target>${java.version}</maven.compiler.target>
	<maven.compiler.release>${java.version}</maven.compiler.release>

Conversation

Stromner commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacekbilski commented Jan 16, 2026

Uh oh!

Stromner commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Stromner commented Jan 26, 2026

Uh oh!

danjee commented Jan 26, 2026

Uh oh!

jacekbilski commented Feb 9, 2026

Uh oh!

Stromner commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacekbilski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacekbilski commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Stromner commented Jan 8, 2026 •

edited

Loading

Stromner commented Jan 23, 2026 •

edited

Loading

Stromner commented Feb 9, 2026 •

edited

Loading