Skip to content

Remove spork#4811

Merged
Gerg merged 1 commit intomainfrom
remove-spork
Mar 10, 2026
Merged

Remove spork#4811
Gerg merged 1 commit intomainfrom
remove-spork

Conversation

@Gerg
Copy link
Member

@Gerg Gerg commented Jan 27, 2026

  • Spork is old and unsupported
  • I wasn't able to get it working with modern ruby
  • Spring is the modern implementation of the same concept

Continuation of #4802


Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • [x I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@Gerg Gerg marked this pull request as ready for review February 11, 2026 07:26
@Gerg Gerg mentioned this pull request Mar 3, 2026
5 tasks
@johha
Copy link
Contributor

johha commented Mar 3, 2026

@Gerg Are you still working on this or is this ready for review?

@Gerg
Copy link
Member Author

Gerg commented Mar 3, 2026

Should be good to go

@johha
Copy link
Contributor

johha commented Mar 3, 2026

Should be good to go

I think a rebase would be good - also for the other PRs

johha
johha previously approved these changes Mar 4, 2026
Copy link
Contributor

@johha johha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Spork is old and unsupported
- I wasn't able to get it working with modern ruby
- Spring is the modern implementation of the same concept
@Gerg Gerg merged commit fa6960e into main Mar 10, 2026
11 checks passed
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Mar 10, 2026
Changes in cloud_controller_ng:

- Remove Spork preloader
    PR: cloudfoundry/cloud_controller_ng#4811
    Author: Greg Cobb <greg.cobb@broadcom.com>
@moleske moleske deleted the remove-spork branch March 10, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants