Add support for configurable SSH algorithms in diego-sshd#4914
Open
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Open
Add support for configurable SSH algorithms in diego-sshd#4914philippthun wants to merge 1 commit intocloudfoundry:mainfrom
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
Add configuration schema and implementation to allow operators to configure SSH algorithms (ciphers, host key algorithms, key exchanges, and MACs) for diego-sshd running in app containers. The diego.sshd configuration accepts comma-separated strings for each algorithm type. When configured, these values are passed as command-line flags to diego-sshd (using -allowedCiphers, -allowedHostKeyAlgorithms, -allowedKeyExchanges, -allowedMACs). Empty strings result in no flags being passed, allowing diego-sshd to use its defaults. Both the sshd section and individual algorithm options are optional in all schemas (api, worker, clock, and deployment_updater), allowing operators to configure only the algorithms they need to restrict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration schema and implementation to allow operators to configure SSH algorithms (ciphers, host key algorithms, key exchanges, and MACs) for
diego-sshdrunning in app containers.The
diego.sshdconfiguration accepts comma-separated strings for each algorithm type. When configured, these values are passed as command-line flags to diego-sshd (using-allowedCiphers,-allowedHostKeyAlgorithms,-allowedKeyExchanges,-allowedMACs). Empty strings result in no flags being passed, allowingdiego-sshdto use its defaults.Both the
sshdsection and individual algorithm options are optional in all schemas (api, worker, clock, and deployment_updater), allowing operators to configure only the algorithms they need to restrict.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests