Open
Conversation
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HDR option for Cloudinary video transformations
Summary
Adds an
hdr: trueoption so the player applies Cloudinary HDR transformations (vc_h265,dr_high) when the device and screen support HDR.Changes
Feature
src/video-player.const.js: AddedhdrtoSOURCE_PARAMSsrc/plugins/cloudinary/models/video-source/video-source.js: Whenhdr: trueandmatchMedia('(dynamic-range: high)').matches, merges{ video_codec: 'h265', raw_transformation: 'dr_high' }into the transformationsrc/plugins/cloudinary/models/video-source/video-source.const.js: Addedhdr: falsetoDEFAULT_VIDEO_PARAMSNote:
dr(dynamic range) is not yet supported by@cloudinary/url-gen, sodr_highis applied viaraw_transformation.Input validation
src/config/configSchema.json: Addedhdr: { type: "boolean", default: false }src/validators/validators.js: Addedhdr: validator.isBooleantosourceValidatorsAnalytics
src/utils/get-analytics-player-options.js: Includedhdrin source options for analyticsExample pages
docs/hdr.html: NonESM example withcloud_name: 'prod',publicId: 'video/examples/hdr', and an "Enable HDR" toggledocs/es-modules/hdr.html: ESM example with the same setupdocs/index.htmlanddocs/es-modules/index.html: Added HDR linksE2E tests
test/e2e/testData/ExampleLinkNames.ts: AddedHDRtest/e2e/testData/pageLinksData.tsandesmPageLinksData.ts: Added HDR page linkstest/e2e/src/pom/hdrPage.ts: New page objecttest/e2e/src/pom/PageManager.ts: AddedhdrPagegettertest/e2e/specs/commonSpecs/hdrPageVideoPlaying.ts: Shared spec for HDR pagetest/e2e/specs/NonESM/hdrPage.spec.tsandtest/e2e/specs/ESM/esmHdrPage.spec.ts: E2E specsUnit tests
test/unit/videoSource.test.js: Addeddescribe('HDR option tests')with 4 tests:hdr: true+ HDR supported → URL containsvc_h265anddr_highhdr: true+ HDR not supported → URL does not containdr_highhdr: false→ no HDR transformationhdrnot set → no HDR transformationUsage
player.source('video/examples/hdr', { hdr: true, info: { title: 'HDR' } });