Skip to content

fix(ui): correct SPDX license header format in generateTailwindThemeClassesJson.ts#1501

Closed
ArtieReus wants to merge 1 commit intomainfrom
artie-fix-reuse
Closed

fix(ui): correct SPDX license header format in generateTailwindThemeClassesJson.ts#1501
ArtieReus wants to merge 1 commit intomainfrom
artie-fix-reuse

Conversation

@ArtieReus
Copy link
Collaborator

@ArtieReus ArtieReus commented Mar 3, 2026

Summary

  • Fixed invalid SPDX license expression in
    packages/ui-components/src/docs/ColorPalette/generateTailwindThemeClassesJson.ts
  • Changed license header from line comments (//) to proper block comment format (/* */)

Problem

The REUSE API reported the file as having an invalid SPDX license expression because the
license header was commented out with // prefixes, which doesn't match the standard
format.

Solution

Updated the SPDX header to use the standard /* */ block comment format consistent with all
other files in the project.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@ArtieReus ArtieReus requested review from a team and franzheidl as code owners March 3, 2026 16:23
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: 3d6bf58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ArtieReus ArtieReus self-assigned this Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-04 11:09 UTC

@ArtieReus ArtieReus changed the title fix(reuse): correct SPDX license header format in generateTailwindThemeClassesJson.ts fix(ui): correct SPDX license header format in generateTailwindThemeClassesJson.ts Mar 3, 2026
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue in the error is that Apache-2.0\n is detected as INVALID SPDX LICENSE EXPRESSIONS.

Screenshot 2026-03-03 at 23 00 59

The format of the comment you adjusted doesn't fix this, these lines are correctly read as the expected license. See my local test.

Screenshot 2026-03-03 at 23 09 27

We need to understand if the script in generateTailwindThemeClassesJson.ts is still needed, since it doesn't seem to be actually called, referenced anywhere.

If so, we need to somehow change the format or ignore those lines. If not, delete.

As agreed, I'll investigate and open a PR then.

@ArtieReus ArtieReus closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants