fix: Disable revive var-naming lint errors for standard library package names#612
Merged
erezrokah merged 4 commits intorenovate/golangci-golangci-lint-2.xfrom Mar 2, 2026
Merged
Conversation
1 task
Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com>
Claude
AI
changed the title
Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com>
Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com>
Claude
AI
changed the title
erezrokah
requested review from
Copilot and
hermanschaaf
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Adjusts lint suppression and repo hygiene to accommodate stricter revive var-naming checks introduced by the golangci-lint upgrade, while keeping intentional package naming unchanged.
Changes:
- Added
//nolint:reviveonpackage metricsto suppressrevivevar-naming warnings for the package name. - Added
//nolint:reviveonpackage pluginin the Arrow protobuf test package for the samerevivewarning. - Updated
.gitignoreto ignore thebin/directory.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pb/plugin/v3/arrow_test.go |
Suppresses revive var-naming on the plugin package declaration in tests. |
metrics/metrics.go |
Suppresses revive var-naming on the metrics package declaration. |
.gitignore |
Ignores bin/ output directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
erezrokah
added a commit
that referenced
this pull request
Mar 2, 2026
* chore(deps): Update dependency golangci/golangci-lint to v2.10.1 * fix: Disable revive var-naming lint errors for standard library package names (#612) * Initial plan * fix: Disable revive var-naming lint errors for package names Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com> * Verify linter passes with no errors Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com> * chore: Remove binary from git and update .gitignore Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com> --------- Co-authored-by: Claude <242468646+Claude@users.noreply.github.com> Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The golangci-lint upgrade to v2.10.1 introduced stricter
revivevar-naming checks that flag package names conflicting with Go standard library, specificallymetricsandplugin.Changes
//nolint:revivedirectives to suppress var-naming warnings on package declarations:metrics/metrics.go- package name intentionally matches metrics domainpb/plugin/v3/arrow_test.go- package name follows protobuf structure conventions.gitignoreto excludebin/directoryBoth packages are appropriately named for their context despite standard library conflicts.