Skip to content

fix: suppress revive var-naming lint errors for metrics and plugin package names#613

Closed
Copilot wants to merge 2 commits intorenovate/golangci-golangci-lint-2.xfrom
copilot/sub-pr-610
Closed

fix: suppress revive var-naming lint errors for metrics and plugin package names#613
Copilot wants to merge 2 commits intorenovate/golangci-golangci-lint-2.xfrom
copilot/sub-pr-610

Conversation

Copy link

Copilot AI commented Mar 2, 2026

golangci-lint v2.10.1 introduced a stricter revive var-naming rule that flags package names conflicting with Go standard library names. Two packages in this repo trip this rule: metrics and plugin.

Changes

  • metrics/metrics.go — add //nolint:revive to package declaration
  • pb/plugin/v3/arrow_test.go — add //nolint:revive to package declaration

Renaming these packages would be a breaking API change; inline suppression is the minimal fix.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…_test

Co-authored-by: erezrokah <26760571+erezrokah@users.noreply.github.com>
Copy link
Author

Copilot AI commented Mar 2, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.cloudquery.io
    • Triggering command: /tmp/go-build1419120576/b058/managedplugin.test /tmp/go-build1419120576/b058/managedplugin.test -test.testlogfile=/tmp/go-build1419120576/b058/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build1419120576/b307/vet.cfg submodules | heaIlJ__Wu3yPWTexD7dPDP/IlJ__Wu3yPWTexD7dPDP cgo .2/x64/codeql/cogo1.24.13 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update dependency golangci/golangci-lint to v2.10.1 fix: suppress revive var-naming lint errors for metrics and plugin package names Mar 2, 2026
@erezrokah erezrokah closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants