Conversation
Co-authored-by: jingnigg <jingnigg@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
I refactored stream-related exceptions, primarily replacing
Learn more about Cursor Agents |
Co-authored-by: jingnigg <jingnigg@gmail.com>
Member
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redefine
ConnectionExceptionas an internal control-flow exception and introduce event-driven lifecycle callbacks (onClose,onReadableEnd,onWritableEnd) to provide clear connection state management and robust error handling.The previous
ConnectionExceptionwas ambiguously used for both internal control flow and application-level errors, leading to potential deadlocks in the event loop and unclear user interaction. This refactoring ensures the reactor can reliably terminate connections on fatal I/O errors while empowering users with explicit, event-based notifications for connection lifecycle events, including half-close scenarios.