Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PRs from forks failed CI because the
pull_requestaction event builds on the forked repository and does not have access to this repo's secret in order to pull the github packages during the build.I think this is fairly safe though since we require approval for CI to run for outside contributors - just want to confirm this - or if we can/should require approval for CI run? Noting also that the READ_PACKAGES secret only has the
packages:readpermissions.Any background context you want to provide?
PR from fork with failing build: #6972
tested with a PR from DDF into my forked repo: alexabird#1
Review Comment Legend: