Skip to content

feat(DatapointsAPI): Add missing 'type' field to Datapoints[Array] data classes#2484

Merged
haakonvt merged 2 commits intopysdk-release-v8from
add-dps-type-field
Mar 12, 2026
Merged

feat(DatapointsAPI): Add missing 'type' field to Datapoints[Array] data classes#2484
haakonvt merged 2 commits intopysdk-release-v8from
add-dps-type-field

Conversation

@haakonvt
Copy link
Copy Markdown
Contributor

@haakonvt haakonvt commented Feb 20, 2026

Since we have not released v8 yet, we have a golden opportunity to implement necessary changes just-in-time for release.

Changes

  1. Update protobuf files
  2. Update Datapoints and DatapointsArray to respect required fields
  3. Add the new field 'type' as required

@haakonvt haakonvt requested review from a team as code owners February 20, 2026 19:47
gemini-code-assist[bot]

This comment was marked as outdated.

@haakonvt haakonvt force-pushed the add-dps-type-field branch 5 times, most recently from 9634215 to 02c5c9c Compare March 11, 2026 12:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 84.44444% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.62%. Comparing base (b93f588) to head (b78ec1e).
⚠️ Report is 4 commits behind head on pysdk-release-v8.

Files with missing lines Patch % Lines
cognite/client/utils/_datapoints.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           pysdk-release-v8    #2484   +/-   ##
=================================================
  Coverage             64.61%   64.62%           
=================================================
  Files                   467      467           
  Lines                 47778    47792   +14     
=================================================
+ Hits                  30873    30884   +11     
- Misses                16905    16908    +3     
Files with missing lines Coverage Δ
...ognite/client/data_classes/datapoint_aggregates.py 0.00% <ø> (ø)
cognite/client/data_classes/datapoints.py 58.17% <100.00%> (+0.81%) ⬆️
...te/client/data_classes/datapoints_subscriptions.py 33.33% <ø> (ø)
...ests/tests_integration/test_api/test_datapoints.py 99.30% <100.00%> (ø)
...integration/test_api/test_synthetic_time_series.py 85.56% <ø> (ø)
tests/tests_unit/test_api/test_datapoints.py 100.00% <100.00%> (ø)
.../tests_unit/test_api/test_synthetic_time_series.py 96.25% <100.00%> (ø)
...ts/tests_unit/test_data_classes/test_datapoints.py 100.00% <ø> (ø)
tests/tests_unit/test_data_classes/test_repr.py 100.00% <100.00%> (ø)
...s/tests_unit/test_data_classes/test_time_series.py 90.69% <ø> (ø)
... and 1 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haakonvt haakonvt force-pushed the add-dps-type-field branch from 02c5c9c to dc93da7 Compare March 11, 2026 21:28
@haakonvt haakonvt changed the base branch from pysdk-release-v8 to update-proto-files March 11, 2026 21:29
@cognitedata cognitedata deleted a comment from gemini-code-assist Bot Mar 11, 2026
@haakonvt haakonvt force-pushed the add-dps-type-field branch 3 times, most recently from 45f40a7 to 18de25e Compare March 11, 2026 21:55
Base automatically changed from update-proto-files to pysdk-release-v8 March 12, 2026 06:16
@haakonvt haakonvt force-pushed the add-dps-type-field branch 2 times, most recently from 64911ba to cdbf168 Compare March 12, 2026 12:31
@haakonvt haakonvt force-pushed the add-dps-type-field branch from cdbf168 to b78ec1e Compare March 12, 2026 12:59
@haakonvt haakonvt self-assigned this Mar 12, 2026
@haakonvt haakonvt added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action labels Mar 12, 2026
@haakonvt
Copy link
Copy Markdown
Contributor Author

🦄

@haakonvt haakonvt merged commit d71698e into pysdk-release-v8 Mar 12, 2026
16 checks passed
@haakonvt haakonvt deleted the add-dps-type-field branch March 12, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants