Added tests for migration legacy to room

[rovertrack]

Fixes #6777
relates to parent: #6768

• Write tests using Room's Room.inMemoryDatabaseBuilder() to create tables with legacy code, and prove that room based entities can read from it, and vice-versa. This will let you write a test for step 5, demonstrating that the migration will work correctly.

What changes did you make and why?
added the inmemorydatabasebuilder helper class thanks to @psh comment

added tests

• BookmarkPicturestableTest.kt
• BookmarkItemsTabletest.kt
• CategoryTableTest.kt
• RecentSearchesTableTest.kt
• RecentLanguagesTableTest.kt

all implemented tests passed ✅

[RitikaPahwa4444]

Thanks @rovertrack. I'm reviewing the tests. Meanwhile, could you check the comment I added?

[rovertrack]

@RitikaPahwa4444 please check the latest commit
i have bumped the version and added data migration which moves data of the 5 legacy tables from "commons.db" to "commons_room.db"

wrote MigrationTest.kt which proves that the migration from old legacy db to room db is done suucessfully

before :

after :

also completes #6798

please review this, thanks

[RitikaPahwa4444]

Mostly looks good. I'll test it once and merge.

[Copilot]

Pull request overview

Adds Robolectric/Room-based tests and wiring to support verifying interoperability and migration between the legacy commons.db (content-provider tables) and the Room database as part of the ongoing “content providers → Room” migration plan (issue #6777, parent #6768).

Changes:

• Introduces an InMemoryDatabaseTest base to run Room in-memory DB tests and execute legacy SQL against the same DB.
• Adds per-table tests for legacy table compatibility with new Room entities/DAOs (categories, bookmarks, bookmark items, recent searches, recent languages).
• Bumps Room DB to v22, adds new Room entities/DAOs, and adds a MIGRATION_21_22 intended to copy data from commons.db → commons_room.db.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
app/src/test/kotlin/fr/free/nrw/commons/db/InMemoryDatabaseTest.kt	Base test harness for Room in-memory DB + legacy SQL helpers
app/src/test/kotlin/fr/free/nrw/commons/db/CategoryTableTest.kt	Category legacy↔Room compatibility tests
app/src/test/kotlin/fr/free/nrw/commons/db/BookmarkPictureTableTest.kt	Bookmark pictures legacy↔Room compatibility tests
app/src/test/kotlin/fr/free/nrw/commons/db/BookmarkItemsTableTest.kt	Bookmark items legacy↔Room compatibility tests
app/src/test/kotlin/fr/free/nrw/commons/db/RecentSearchesTableTest.kt	Recent searches legacy↔Room compatibility tests
app/src/test/kotlin/fr/free/nrw/commons/db/RecentLanguagesTableTest.kt	Recent languages legacy↔Room compatibility tests
app/src/test/kotlin/fr/free/nrw/commons/db/MigrationTest.kt	Adds a Robolectric test intended to validate the 21→22 migration
app/src/main/java/fr/free/nrw/commons/db/AppDatabase.kt	Adds new entities/DAOs to Room DB and bumps version to 22
app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.kt	Registers MIGRATION_21_22 and implements data-copy migration logic
app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.kt	Allows injecting a delegate openHelper for tests

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[rovertrack]

@RitikaPahwa4444 I have made the improvements suggested by copilot
please review them .
thanks

[rovertrack]

Thanks @RitikaPahwa4444
this closes #6798 too )

[github-actions]

✅ Generated APK variants!

• 🤖 Download prodDebugAPK
• 🤖 Download betaDebugAPK