Skip to content

feat(pgpm): replace --include with --minio flag for docker command#977

Merged
pyramation merged 2 commits intomainfrom
feat/pgpm-docker-minio-flag
Apr 11, 2026
Merged

feat(pgpm): replace --include with --minio flag for docker command#977
pyramation merged 2 commits intomainfrom
feat/pgpm-docker-minio-flag

Conversation

@pyramation
Copy link
Copy Markdown
Contributor

@pyramation pyramation commented Apr 11, 2026

Summary

Replaces pgpm docker start --include minio with the simpler pgpm docker start --minio, matching the --minio flag pattern already used in pgpm env (PR #976).

  • Removes parseInclude() and resolveIncludedServices() (which parsed --include <name> args and did name lookups with warnings for unknown services)
  • Adds resolveServiceFlags() which checks CLI args directly against ADDITIONAL_SERVICES keys — if args.minio is truthy, the minio service is included
  • Updates help text: moves minio from "Available Additional Services" list to an "Additional Services" section with --minio flag syntax
  • Updates pgpm docker ls hint from --include <name> to --<name> flag
  • Updates display.ts top-level help to show --minio instead of --include for additional services

Breaking: --include minio no longer works. Since #975 was merged very recently, adoption is near-zero.

Review & Testing Checklist for Human

  • Verify --minio flag parsing: Run pgpm docker start --minio and confirm inquirerer parses it as { minio: true } so resolveServiceFlags picks it up. The old --include approach explicitly handled string/array parsing; the new approach assumes the arg parser sets a boolean — confirm this works with the actual CLI arg parser
  • End-to-end test: pgpm docker start --minio (both containers up), pgpm docker ls (shows minio status), pgpm docker stop --minio (both stop)
  • Verify --minio doesn't collide with other args: The new resolveServiceFlags iterates all ADDITIONAL_SERVICES keys and checks args[key] — confirm no existing arg names clash with service names (currently only minio, so low risk)

Notes

  • The extensibility model now requires that each service in ADDITIONAL_SERVICES has a key that works as a CLI flag name (e.g., no spaces, hyphens are fine). This is a reasonable constraint.
  • No automated tests — this is Docker orchestration code that requires a running Docker daemon to test meaningfully.

Link to Devin session: https://app.devin.ai/sessions/44eca4b3fe5a46aaaf5c4907f0a0b600
Requested by: @pyramation

- Replace --include <svc> with direct --minio flag matching pgpm env pattern
- Simplify resolveServiceFlags to check args directly against ADDITIONAL_SERVICES keys
- Remove parseInclude/resolveIncludedServices in favor of simpler resolveServiceFlags
- Update help text and examples to use --minio instead of --include minio
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pyramation pyramation merged commit d6fbd91 into main Apr 11, 2026
49 checks passed
@pyramation pyramation deleted the feat/pgpm-docker-minio-flag branch April 11, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant