vmm: Fix bzip2 magic header detection#622
Open
d-e-s-o wants to merge 1 commit intocontainers:mainfrom
Open
Conversation
The bzip2 magic byte search uses .windows(4) to produce 4-byte slices, but compares them against the 3-byte pattern [b'B', b'Z', b'h']. As a result, we will never see a match. Thus, the bzip2 header is never found, and loading always fails with ImageBz2Invalid (surfacing as EINVAL to callers). Fix the issue by using .windows(3), matching how the gzip path handles its 3-byte magic. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bzip2 magic byte search uses
.windows(4)to produce 4-byte slices, but compares them against the 3-byte pattern[b'B', b'Z', b'h']. As a result, we will never see a match. Thus, the bzip2 header is never found, and loading always fails with ImageBz2Invalid (surfacing as EINVAL to callers).Fix the issue by using
.windows(3), matching how thegzippath handles its 3-byte magic.