[time] Cleanup exposition-only names#9002
Open
frederick-vs-ja wants to merge 1 commit intocplusplus:mainfrom
Open
[time] Cleanup exposition-only names#9002frederick-vs-ja wants to merge 1 commit intocplusplus:mainfrom
frederick-vs-ja wants to merge 1 commit intocplusplus:mainfrom
Conversation
1. Apply `\exposid` to all exposition-only members in [time].
2. For _`local-time-format-t`_ and _`STATICALLY-WIDEN`_, change uses of
`\placeholder` to `\exposid`.
3. Rename some members of `hh_mm_ss`, `zoned_time`, and
_`local-time-format-t`_ in the style of either _`name_`_ or
_`kebab-case`_.
4. Add `\linebreak{}` to [time.hms.members] to avoid overfull `\hbox`.
frederick-vs-ja
force-pushed
the
expos-time
branch
from
b773b36 to
b674580
Compare
jensmaurer
approved these changes
May 6, 2026
Member
jensmaurer
left a comment
jensmaurer
left a comment
There was a problem hiding this comment.
This sprinkles \exposid across the board. It renames data members (by suffixing with _) in only two cases, and those look correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\exposidto all exposition-only members in [time].local-time-format-tandSTATICALLY-WIDEN, change uses of\placeholderto\exposid.hh_mm_ss,zoned_time, andlocal-time-format-tin the style of eithername_orkebab-case.\linebreak{}to [time.hms.members] to avoid overfull\hbox.Towards #5940.