Merged
Conversation
…ion syntax As a side-effect, output syntax now includes the `,` as well, as it must now be included directly in the architecture definition
After testing, `IterInput` seems to be somehow significantly slower than `MappedInput` with a slice
This is rarely used and unsupported by other assemblers, and comes with a significant performance cost (~10.5% overall). This also improves incorrect instruction syntax error messages for expressions (as those couldn't have newlines due to how they were parsed)
Previous implementation incorrectly reported "found '\n' but expected '\n', ..." when there were unrecognised tokens right after the line jump
Closes: #1234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.