Skip to content

feat(executions): add worker_id + status__in filters and oldest_claimed_at on list endpoint#79

Merged
mikemolinet merged 1 commit into
mainfrom
feat/executions-worker-id-filter-fresh
May 11, 2026
Merged

feat(executions): add worker_id + status__in filters and oldest_claimed_at on list endpoint#79
mikemolinet merged 1 commit into
mainfrom
feat/executions-worker-id-filter-fresh

Conversation

@mikemolinet
Copy link
Copy Markdown
Collaborator

Summary

Re-port of closed PR #48 which was on a stale base ~8870 deletions behind main. Fresh against current main via direct patch from the old branch's commit (c05518c).

Adds query-side enrichment to GET /v1/executions:

  • worker_id= — filter to executions claimed by a specific worker (Execution.claimed_by_worker)
  • status__in=foo,bar,baz — comma-separated multi-status filter. Mutex with status=; 400 conflicting_filters if both passed.
  • Response gains oldest_claimed_at — earliest claimed_at over the filtered set, or null when count=0. Unblocks dashboard/menubar "oldest pending: 5m" rendering without a follow-up query.

Use cases

  • Menubar pending counter: fetch pending,delivering,retry_ready in one round trip (status__in), get total + oldest_claimed_at to render "3 in flight, oldest claimed 8m ago".
  • Worker health dashboard: filter by worker_id to scope to one worker's claims; see how stale their oldest claim is.

Changes

File Change
app/routers/executions.py Adds 2 Query params (status__in, worker_id) + mutex check + oldest_claimed_at computation + response field
tests/test_execution_parity.py 3 new tests in TestListExecutions

Tests

3 new tests:

  • worker_id scoping + oldest_claimed_at value reflects earliest claimed_at over filtered set
  • status__in union + status/status__in mutex 400
  • null oldest_claimed_at on empty filtered set

31/31 in test_execution_parity.py green. Zero regressions on full local suite.

Re-port note

Re-port of closed PR #48 (commit c05518c, "feat(executions): add worker_id + status__in filters and oldest_claimed_at"). Branch was ~8870 deletions behind main; fresh against current main after PR #74/#75/#76/#77/#78 merged earlier in this session.

Patch from c05518c applied cleanly to current main — the patch only touches list_executions, which has remained additive (cueapi-core added outcome_state filter since the branch was cut; this PR is compatible).

Test plan

  • 3 new tests pass locally
  • 31/31 in test_execution_parity.py pass
  • Patch applied cleanly to current main (no manual conflict resolution needed)
  • Mutex check (status + status__in) returns 400 with proper error code
  • CI green
  • Admin-merge per agents-merge-own-PRs directive

🤖 Generated with Claude Code

…ed_at on list endpoint

Re-port of closed [PR #48](#48) which was on a stale base ~8870 deletions behind main. Fresh against current main HEAD via direct patch from the old branch's commit (c05518c).

Adds query-side enrichment to ``GET /v1/executions``:

- ``worker_id=`` — filter to executions claimed by a specific worker
  (Execution.claimed_by_worker)
- ``status__in=foo,bar,baz`` — comma-separated multi-status filter.
  Mutex with ``status=``; 400 conflicting_filters if both passed.
- Response gains ``oldest_claimed_at`` — earliest ``claimed_at`` over
  the filtered set, or null when count=0. Unblocks dashboard/menubar
  "oldest pending: 5m" rendering without a follow-up query.

## Use cases

- **Menubar pending counter**: fetch ``pending,delivering,retry_ready``
  in one round trip (status__in), get total + oldest_claimed_at to
  render "3 in flight, oldest claimed 8m ago".
- **Worker health dashboard**: filter by worker_id to scope to one
  worker's claims; see how stale their oldest claim is.

## Tests

3 new tests in TestListExecutions:
- worker_id scoping + oldest_claimed_at value reflects earliest
  claimed_at over filtered set
- status__in union + status/status__in mutex 400
- null oldest_claimed_at on empty filtered set

31/31 in test_execution_parity.py green. Full local suite: zero
regressions.

## Re-port note

Re-port of closed PR #48 (commit c05518c). Branch was ~8870 deletions
behind main; fresh against current main after PR #74/#75/#76/#77/#78
merged earlier in this session. Patch applied cleanly from c05518c
to current main — the patch only touches list_executions endpoint,
which has remained additive (cueapi-core added outcome_state filter
since the branch was cut; this PR is compatible).
@github-actions
Copy link
Copy Markdown

Parity check

This PR modifies files tracked in parity-manifest.json:

  • app/routers/cues.py
  • app/routers/executions.py
  • app/schemas/cue.py

Please confirm one of the following in a reply or PR description update:

  1. The equivalent change has been applied to the private cueapi monorepo. Link the PR.
  2. This change is OSS-only and does not need porting. Briefly explain why (e.g. "fixes a bug that only exists in the OSS build").
  3. A follow-up issue has been filed to port the reverse direction. Link the issue.

This is a soft check — it does not block merge. The goal is visibility, not friction. See HOSTED_ONLY.md for the open-core policy.

@govindkavaturi-art govindkavaturi-art enabled auto-merge (squash) May 11, 2026 16:20
@mikemolinet mikemolinet merged commit 22970bc into main May 11, 2026
6 checks passed
@mikemolinet mikemolinet deleted the feat/executions-worker-id-filter-fresh branch May 11, 2026 16:21
mikemolinet added a commit that referenced this pull request May 11, 2026
…ueapi/cueapi#630) (#80)

Re-port of closed [PR #47](#47) which was on a stale base ~8880 deletions behind main. Fresh against current main HEAD.

Phase A of the Agent Directory productization. Eliminates the failure
mode where agents had to remember 6+ fields per recipient AND had no
way to discover the live roster.

## What lands

- **GET /v1/agents/roster** — display-optimized snapshot for prompt-
  injection at session-boot. Distinct from the existing management
  surface (GET /v1/agents):
  - Always-full list (no pagination)
  - Drops opaque IDs / secrets / timestamps / tenancy metadata
  - Adds derived ``online``, ``last_seen_relative``, ``preferred_contact``
  - Always excludes soft-deleted agents
  - Weak ETag + ``If-None-Match`` → 304 Not Modified for poll efficiency
  - ETag bucketed to 5-min windows so quiet periods produce stable hashes
  - ``Cache-Control: private, max-age=300`` matches derivation buckets

- **Migration 031** (renumbered from private's 048) — adds
  ``agents.last_seen_at TIMESTAMPTZ NULL``. Nullable, no backfill.

- **Hot-path hooks** write ``last_seen_at = now()``:
  - ``create_message`` — sender's agent (in same tx via touch_last_seen)
  - ``list_inbox`` — recipient's agent, on EVERY poll (via
    _bump_last_seen_stmt). Even when no queued messages exist, the
    poll proves activity.

- **Online derivation** (server-computed in ``list_roster``):
  - within 5 min   → ``online``
  - within 30 min  → ``away``
  - older or NULL  → ``offline``
  - Caller override wins: PATCHed status=away/offline keeps that
    override regardless of recent activity

## Pure helpers (for unit-testability — pytest-cov + ASGI issue)

- ``_build_roster_entry(agent, now)`` in agent_service.py: ORM Agent
  → (entry_dict, etag_part_string)
- ``_compute_roster_etag(parts)`` in agent_service.py: list → weak ETag
- ``_derive_online_state(now, last_seen_at, asserted_status)`` →
  (online_bool, derived_status)
- ``_format_relative(now, last_seen_at)`` → "active now" / "5m ago" / ...
- ``_bucketed_seen(last_seen_at)`` → string for ETag stability
- ``_bump_last_seen_stmt(agent_id, now)`` in inbox_service.py:
  SQLAlchemy UPDATE statement
- ``_etag_matches(if_none_match, server_etag)`` in agents router:
  conditional GET predicate

## Tests

27 new tests in tests/test_agent_roster.py (verbatim from private):
shape verification, hot-path hooks (sender + recipient), derivation
correctness across all 3 buckets, caller-asserted status override,
soft-delete exclusion, preferred_contact derivation,
last_seen_relative formatting, ETag 304 handling, ETag changes when
roster mutates, pure-helper unit tests.

27/27 pass locally. Full local suite: 890 passed + 18 xfailed
(pre-existing) + 4 skipped. Zero regressions.

## Re-port note

Re-port of closed PR #47. Fresh against current main after PR #74 +
#75 + #76 + #77 + #78 + #79 merged earlier in this session.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant