CM-60184-Scans using presigned post url#395
Merged
mateusz-sterczewski merged 9 commits intomainfrom Mar 3, 2026
Merged
Conversation
mateusz-sterczewski
requested review from
elsapet and
gotbadger
as code owners
elsapet
previously approved these changes
Mar 3, 2026
elsapet
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the way we are doing the zip uploads, instead of sending it as multipart form (and splitting it in chunks).
Now, we're going to call the API to get presigned POST url, and we can upload to S3 using this data. Then, when starting the scan, we use
uploadIdto indicate the location in S3 of the zip.Enabled for SAST only and we are increasing the max size of single zip from 50MB to 5GB