Skip to content

Version Packages #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daangnbot wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −6
Open

Version Packages #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/fix-transition-duration-zero-jitter.md
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# @stackflow/core

## 1.3.2

### Patch Changes

- 0160f82: Fix intermittent incorrect transition state when `transitionDuration` is set to 0 by ensuring `now >= eventDate` in the initial aggregate call within `dispatchEvent`.
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify where aggregate(now) guards are applied in makeCoreStore
fd -i makeCoreStore.ts --exec rg -n -C3 'aggregate\(|Math\.max\(|new Date\(\)\.getTime\(\)'

Repository: daangn/stackflow

Length of output: 790

Clarify wording in the release note to avoid confusion between store initialization and dispatchEvent.

The phrase "initial aggregate call within dispatchEvent" risks ambiguity. The store initialization (line 84) also calls aggregate without the guard, while dispatchEvent (lines 96-99) applies Math.max(newEvent.eventDate, new Date().getTime()) to ensure the condition. Reword to explicitly state the fix applies to the aggregate call inside dispatchEvent, not during store initialization. Example: "ensuring now >= eventDate in the aggregate call within dispatchEvent" (dropping "initial").

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@core/CHANGELOG.md` at line 7, Update the changelog entry to remove ambiguity
by explicitly stating the fix targets the aggregate call inside dispatchEvent
(not store initialization); change the sentence to mention "ensuring now >=
eventDate in the aggregate call within dispatchEvent" and keep references to
transitionDuration, eventDate, and dispatchEvent so reviewers can locate the
relevant logic (see aggregate call inside dispatchEvent and the separate
aggregate call during store initialization).


## 1.3.1

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@stackflow/core",
"version": "1.3.1",
"version": "1.3.2",
"repository": {
"type": "git",
"url": "https://github.com/daangn/stackflow.git",
Expand Down
9 changes: 9 additions & 0 deletions docs/components/ChangelogContent.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## 2026.04.03

Fix intermittent incorrect transition state when `transitionDuration` is set to 0 by ensuring `now >= eventDate` in the initial aggregate call within `dispatchEvent`. [`0160f82`](https://github.com/daangn/stackflow/commit/0160f82738e45932d13715564c4d1da2c4698c18)

Released packages:
- 📦 [@stackflow/core@1.3.2](https://npmjs.com/package/@stackflow/core/v/1.3.2)

---

## 2026.03.30

Add blockerPlugin and useBlocker hook for navigation blocking [`c740c5e`](https://github.com/daangn/stackflow/commit/c740c5e28c30afc23fff8705c405cefa514a1f35)
Expand Down
Loading