Draft
Conversation
Add GuiScrollContainer, a subclass of GuiContainer to support arbitrary and nested scrolling elements. This relies on changes in SeriousProton to implement GL_SCISSOR_TEST in RenderTarget. Child element positions and click/hover handling are translated relative to the scroll position. These containers can be nested, and mousewheel and scroll events are passed down the tree. This container element can also replace the bespoke scrolling behaviors in other element types, such as GuiListbox. - Pass focus, text input through GuiScrollContainer. - Position nested GuiSelector popups relative to scroll translation - Add scrollToOffset() function to allow other elements to control scroll position. - Handle layout padding in scissor rects.
- Use pragma once guard - Internal consistency in formatting - Expand terse varnames - Remove redundant public/protected sections in the header
oznogon
force-pushed
the
refactor-hotkeymenu-hotkeybinder
branch
from
244bc38 to
c841fe5
Compare
Increase the default scrollbar click_change on GuiScrollContainer to 50, matching mousewheel scroll increments.
Redesign HotkeyMenu to use a standardized scrolling container, and to split binding inputs into device groups. - Use GuiScrollContainer to make the hotkeys list vertically scrolling instead of horizontally paged. - Use layout attributes for top-level GUI elements. - Split HotkeyMenu binders into keyboard, joystick, and mouse. - Allow binding escape control without triggering it. - Forward-declare GUI subclasses.
- Allow binder to limit scope to mouse, keyboard, or joystick/ gamecontroller types. - Allow binding left/right click without immediately canceling or rebinding. - Update right click to pop last bind instead of clearing all binds. - Prevent premature clearing of binder field before input occurs.
oznogon
force-pushed
the
refactor-hotkeymenu-hotkeybinder
branch
from
c841fe5 to
2f44a8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft demonstrates usage of #2775 and stacks on that PR. 2775 requires daid/SeriousProton#300, and CI will fail without SP 300.
Replace the bespoke HotkeyMenu pagination with GuiScrollContainer, and split the input field for each control into separate fields for keyboard, joystick, and mouse binds, with each input filtered by input device type. This also allows for mouse axis, wheel, and button binding.
Right-clicking a field now also clears only the last bind from an input field instead of clearing all of its binds.
Contributes to #2772.
Before:
Screencast_20260310_201014.webm
After:
Screencast_20260310_200821.webm