fix: make warehouseId optional in ServiceContext when no plugin requires it#91
Draft
pffigueiredo wants to merge 5 commits intomainfrom
Draft
fix: make warehouseId optional in ServiceContext when no plugin requires it#91pffigueiredo wants to merge 5 commits intomainfrom
pffigueiredo wants to merge 5 commits intomainfrom
Conversation
pffigueiredo
requested review from
MarioCadenas and
pkosiec
and removed request for
MarioCadenas
Adds a `static requires` mechanism to the Plugin class so plugins can declare which shared resources they need (e.g. warehouseId). At startup, createApp() collects requirements from all plugins and passes them to ServiceContext.initialize(), which only resolves warehouseId when a plugin declared it. Apps using only server() no longer need DATABRICKS_WAREHOUSE_ID set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Pedro Figueiredo <klisarkk@gmail.com>
pffigueiredo
force-pushed
the
fix-required-warehouseID
branch
from
7f4191c to
f5e252d
Compare
Author
|
This is in Draft due to clash with other features that are being worked on right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
warehouseIdoptional inServiceContextwhen no registered plugin declares it as a required resource. Previously,ServiceContext.createContext()unconditionally calledgetWarehouseId(client), which in production throws ifDATABRICKS_WAREHOUSE_IDis unset, and in dev mode fires an unnecessary API call.This change introduces a plugin resource declaration system where plugins can specify which shared resources they need (e.g.,
warehouseId). OnlyAnalyticsPluginuses the warehouse ID, so apps using onlyserver()should not require it.FEATURES
static requiredResources: ServiceContextResource[]ServiceContext.initialize()accepts a list of required resources and only resolves them when neededAppKit._createApp()collects required resources from all registered plugins before initializing contextFIXES
createApp({ plugins: [server()] })no longer fails whenDATABRICKS_WAREHOUSE_IDis missingBREAKING CHANGES
requiredResourcesis optional on plugins)Test Plan
server()plugin work withoutDATABRICKS_WAREHOUSE_IDanalytics()plugin continue to requireDATABRICKS_WAREHOUSE_ID