Centralize variable reference check in libs/dyn/convert #4447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the `dynvar.IsPureVariableReference` check from individual type-specific functions to the entry points of `ToTyped`, `Normalize`, and `FromTyped`. This removes repetitive code (~21 checks) and ensures the behavior cannot be forgotten when adding new type handlers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: b617011
41 interesting tests: 21 FAIL, 7 KNOWN, 5 SKIP, 5 RECOVERED, 3 flaky
Top 50 slowest tests (at least 2 minutes):
|
denik
reviewed
Feb 5, 2026
| } | ||
|
|
||
| // If the reference is a pure variable reference, return it verbatim. | ||
| // String is excluded because it can hold the reference as a literal value. |
Contributor
There was a problem hiding this comment.
// String is excluded because it can hold the reference as a literal value.
Unclear, why exclude a string here?
| // String and Interface are excluded because they can hold the reference as a value. | ||
| if dstv.Kind() != reflect.String && dstv.Kind() != reflect.Interface { | ||
| if src.Kind() == dyn.KindString && dynvar.IsPureVariableReference(src.MustString()) { | ||
| dstv.SetZero() |
Contributor
There was a problem hiding this comment.
if destination is integer is reference points to integer, we should not zero it, right?
andrewnester
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move the
dynvar.IsPureVariableReferencecheck from individual type-specific functions to the entry points ofToTyped,Normalize, andFromTyped.This removes repetitive code (~21 checks) and ensures the behavior cannot be forgotten when adding new type handlers.
Why
Discussed here: #4385 (comment)
Tests
Existing tests pass.