-
Notifications
You must be signed in to change notification settings - Fork 142
[Internal] Update Go SDK to v0.106.0 #4486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Commit: a3afe13
67 interesting tests: 29 FAIL, 21 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
| resources.jobs.*.environments[*] jobs.JobEnvironment ALL | ||
| resources.jobs.*.environments[*].environment_key string ALL | ||
| resources.jobs.*.environments[*].spec *compute.Environment ALL | ||
| resources.jobs.*.environments[*].spec.base_environment string ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlight: updated manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that needed?
You can run make test-update to update test fixtures, including this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there were some test failures, will update it using make test-update command
pietern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include the SDK version in the PR title.
| github.event_name == 'workflow_dispatch' || | ||
| github.repository == 'databricks/databricks-sdk-go' || | ||
| github.repository == 'databricks/databricks-sdk-py' || | ||
| github.repository == 'databricks/databricks-sdk-java' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this. We don't want to auto-release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was generated automatically, will revert
| resources.jobs.*.environments[*] jobs.JobEnvironment ALL | ||
| resources.jobs.*.environments[*].environment_key string ALL | ||
| resources.jobs.*.environments[*].spec *compute.Environment ALL | ||
| resources.jobs.*.environments[*].spec.base_environment string ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that needed?
You can run make test-update to update test fixtures, including this one.
Changes
Idto WorkspaceIDNote: This PR doesn't include the changes for CLI specific WorkspaceId eg in AuthArguments, those would be done in separate PR to keep this PR specific to Go SDK bump. The other PR would be created once this is merged.
Why
Best practice to use
IDTests
Existing tests