acc: add cleanup trap to postgres acceptance tests #4489

pietern · 2026-02-10T21:15:48Z

Summary

Add cleanup trap to ensure postgres branches and endpoints are destroyed after tests complete, preventing resource leaks.

Test plan

Run affected acceptance tests:

go test ./acceptance -run TestAccept/bundle/resources/postgres_branches/without_branch_id
go test ./acceptance -run TestAccept/bundle/resources/postgres_endpoints/without_endpoint_id

🤖 Generated with Claude Code

Add cleanup function with trap to ensure postgres branches and endpoints are destroyed after tests complete, preventing resource leaks. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

eng-dev-ecosystem-bot · 2026-02-10T21:39:55Z

Commit: 06e0d36

Run: 21882709006

	Env	❌FAIL	🟨KNOWN	🔄flaky	💚RECOVERED	🙈SKIP	✅pass	🙈skip	Time
🟨	aws linux		7	4	1	7	447	731	28:54
🟨	aws windows		7	2	1	7	415	741	23:19
❌	aws-ucws linux	7	1	2	10	5	698	584	64:13
❌	aws-ucws windows	7	1	2	11	5	660	595	53:59
🔄	azure linux			2	2	9	449	730	23:10
🔄	azure windows			4	2	9	413	740	23:24
🔄	azure-ucws linux			5	6	7	663	595	50:40
💚	azure-ucws windows				6	7	631	606	41:36
💚	gcp linux				2	9	440	736	20:41
💚	gcp windows				2	9	406	746	20:31

42 interesting tests: 19 flaky, 7 KNOWN, 7 FAIL, 5 SKIP, 4 RECOVERED

	Test Name	aws linux	aws windows	aws-ucws linux	aws-ucws windows	azure linux	azure windows	azure-ucws linux	azure-ucws windows	gcp linux	gcp windows
🟨	TestAccept	🟨K	🟨K	🟨K	🟨K	💚R	💚R	💚R	💚R	💚R	💚R
🙈	TestAccept/bundle/deployment/bind/alert	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/generate/alert	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/invariant/no_drift	🙈S	🙈S	🔄f	💚R	🙈S	🙈S	💚R	💚R	🙈S	🙈S
🔄	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl			🔄f	✅p			✅p	✅p
🙈	TestAccept/bundle/resources/alerts/basic	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/alerts/with_file	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/resources/apps/inline_config	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/dashboards/change-embed-credentials	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/resources/dashboards/change-embed-credentials/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p
🙈	TestAccept/bundle/resources/permissions	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions	🟨K	🟨K	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions	🟨K	🟨K	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	🟨K	🟨K	💚R	💚R
❌	TestAccept/bundle/resources/postgres_endpoints/basic	🙈s	🙈s	❌F	❌F	🙈s	🙈s	🙈s	🙈s	🙈s	🙈s
❌	TestAccept/bundle/resources/postgres_endpoints/basic/DATABRICKS_BUNDLE_ENGINE=direct			❌F	❌F
❌	TestAccept/bundle/resources/postgres_endpoints/basic/DATABRICKS_BUNDLE_ENGINE=terraform			❌F	❌F
❌	TestAccept/bundle/resources/postgres_endpoints/recreate	🙈s	🙈s	❌F	❌F	🙈s	🙈s	🙈s	🙈s	🙈s	🙈s
❌	TestAccept/bundle/resources/postgres_endpoints/update_autoscaling	🙈s	🙈s	❌F	❌F	🙈s	🙈s	🙈s	🙈s	🙈s	🙈s
❌	TestAccept/bundle/resources/postgres_endpoints/update_autoscaling/DATABRICKS_BUNDLE_ENGINE=direct			❌F	❌F
❌	TestAccept/bundle/resources/postgres_endpoints/update_autoscaling/DATABRICKS_BUNDLE_ENGINE=terraform			❌F	❌F
💚	TestAccept/bundle/resources/synced_database_tables/basic	🙈S	🙈S	💚R	💚R	🙈S	🙈S	💚R	💚R	🙈S	🙈S
💚	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct			💚R	💚R			💚R	💚R
💚	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform			💚R	💚R			💚R	💚R
🔄	TestAccept/bundle/templates/default-python/combinations/serverless	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_BUNDLE_ENGINE=direct/DLT=no/NBOOK=no/PY=no/READPLAN=1	🙈s	🙈s	✅p	✅p	🙈s	🙈s	🔄f	✅p	🙈s	🙈s
🔄	TestAccept/bundle/templates/default-python/integration_classic	✅p	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.13	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=direct/UV_PYTHON=3.9	🔄f	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.10	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.11	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.12	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p
💚	TestAccept/ssh/connection	💚R	💚R	💚R	💚R	💚R	💚R	💚R	💚R	💚R	💚R
🔄	TestFsCpDirToDirWithOverwriteFlag	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestFsCpDirToDirWithOverwriteFlag/dbfs_to_dbfs	✅p	✅p	✅p	✅p	🔄f	🔄f	✅p	✅p	✅p	✅p
🔄	TestFsCpDirToDirWithOverwriteFlag/dbfs_to_local	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestFsCpFileToFileWithOverwriteFlag	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p
🔄	TestFsCpFileToFileWithOverwriteFlag/dbfs_to_dbfs	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p

Top 50 slowest tests (at least 2 minutes):

duration	env	testname
8:24	aws-ucws windows	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
7:58	aws-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct
7:40	aws-ucws windows	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct
7:36	aws-ucws linux	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
7:09	aws-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
7:01	aws-ucws windows	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform
6:56	aws-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
6:53	aws-ucws linux	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
6:40	aws-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
6:36	aws-ucws windows	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
6:22	aws-ucws linux	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
6:04	aws-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform
5:54	aws-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
5:51	aws-ucws linux	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
5:44	aws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:37	aws-ucws linux	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
5:29	azure linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:28	gcp windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:26	gcp linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:24	aws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:24	aws-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:23	gcp windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:23	azure linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:22	aws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:21	aws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:17	aws-ucws windows	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
5:13	gcp linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:12	azure windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:05	azure-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:31	azure-ucws windows	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform
4:27	azure-ucws linux	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
4:26	azure windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
4:25	azure-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:24	azure-ucws windows	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
4:19	azure-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform
4:18	aws-ucws linux	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
4:17	azure-ucws linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
4:12	azure-ucws windows	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
4:07	azure windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
4:05	azure-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
4:05	azure-ucws linux	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
4:04	azure-ucws linux	TestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_instance.yml.tmpl
3:56	azure-ucws linux	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct
3:54	aws-ucws linux	TestAccept/ssh/connection
3:53	azure-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=database_catalog.yml.tmpl
3:52	azure windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:35	aws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:33	aws-ucws windows	TestAccept/ssh/connection
3:33	azure-ucws windows	TestAccept/bundle/invariant/no_drift/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=synced_database_table.yml.tmpl
3:17	gcp windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform

acc: add cleanup trap to postgres acceptance tests

06e0d36

Add cleanup function with trap to ensure postgres branches and endpoints are destroyed after tests complete, preventing resource leaks. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

pietern requested review from andrewnester, anton-107, denik and shreyas-goenka as code owners February 10, 2026 21:15

pietern temporarily deployed to test-trigger-is February 10, 2026 21:16 — with GitHub Actions Inactive

pietern enabled auto-merge February 10, 2026 21:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

acc: add cleanup trap to postgres acceptance tests #4489

acc: add cleanup trap to postgres acceptance tests #4489

pietern commented Feb 10, 2026

Uh oh!

eng-dev-ecosystem-bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

acc: add cleanup trap to postgres acceptance tests #4489

Are you sure you want to change the base?

acc: add cleanup trap to postgres acceptance tests #4489

Conversation

pietern commented Feb 10, 2026

Summary

Test plan

Uh oh!

eng-dev-ecosystem-bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eng-dev-ecosystem-bot commented Feb 10, 2026 •

edited

Loading