Separate Databricks OIDC endpoint logic into a separate method #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Separate Databricks OIDC endpoint logic into a separate method.
The
getOidcEndpoints()property was incorrectly returning Azure OIDC endpoints whenARM_CLIENT_IDwas set, even for Databricks OAuth flows (likeoauth-m2m) that don't use Azure authentication.This was changed on a previous PR to fix M2M authentication: #657
Given that some users may be depending on this behavior, this PR returns the previous behavior to this method and instead creates a dedicated
getDatabricksOidcEndpoints()method.How is this tested?
Run unit tests and integration tests with appropriate environment variables set.